search

clangd / clangd

clangd language server
https://clangd.llvm.org
Apache License 2.0
1.56k stars 64 forks source link

Release checklist for clangd 19 #2127

Open HighCommander4 opened 2 months ago

HighCommander4 commented 2 months ago

Using the Release checklist from the wiki as a template:

Once the release branch is created

Once the LLVM release is out

nicovank commented 2 months ago

Should TidyFastChecks.inc be updated?

HighCommander4 commented 2 months ago

Should TidyFastChecks.inc be updated?

I will leave this to @sam-mccall / @kadircet to do at a cadence of their choosing.

HighCommander4 commented 2 months ago
  • [ ] Document any notable new features on the clangd website

The only notable new feature that comes to mind is the initial support for C++20 Modules.

@ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

ChuanqiXu9 commented 2 months ago
  • [ ] Document any notable new features on the clangd website

The only notable new feature that comes to mind is the initial support for C++20 Modules.

@ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

I think we should add it. It will pretty helpful for us to improve this by receiving more issue reports.

HighCommander4 commented 2 months ago

The only notable new feature that comes to mind is the initial support for C++20 Modules. @ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

I think we should add it. It will pretty helpful for us to improve this by receiving more issue reports.

Makes sense. Would you like to send a PR? The page source is at https://github.com/llvm/clangd-www/blob/main/features.md.

ChuanqiXu9 commented 2 months ago

The only notable new feature that comes to mind is the initial support for C++20 Modules. @ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

I think we should add it. It will pretty helpful for us to improve this by receiving more issue reports.

Makes sense. Would you like to send a PR? The page source is at https://github.com/llvm/clangd-www/blob/main/features.md.

I sent it here: https://github.com/llvm/clangd-www/pull/107

kadircet commented 2 months ago

Should TidyFastChecks.inc be updated?

I will leave this to @sam-mccall / @kadircet to do at a cadence of their choosing.

thanks for the ping! https://github.com/llvm/llvm-project/pull/106354 for analysis at 19.x, we should also get that cherry-picked to release branch

HighCommander4 commented 2 months ago

I've prepared a 19.1.0 release at https://github.com/clangd/clangd/releases/tag/19.1.0. Marked as pre-release for now, testing is welcome.

HighCommander4 commented 1 month ago

I've now unchecked the pre-release checkbox.

HighCommander4 commented 1 month ago

Note that a crash regression affecting 19.1.0 has been found and fixed on trunk in https://github.com/llvm/llvm-project/issues/109367. I've proposed backporting the fix to the 19.x branch in https://github.com/llvm/llvm-project/issues/111317.

I would like to wait for that fix to appear in a release before marking a 19.x release as "latest".

amitrahman1026 commented 1 month ago

Note that a crash regression affecting 19.1.0 has been found and fixed on trunk in llvm/llvm-project#109367. I've proposed backporting the fix to the 19.x branch in llvm/llvm-project#111317.

I would like to wait for that fix to appear in a release before marking a 19.x release as "latest".

I've also encountered the aforementioned bug, where I talked about it here (with backtrace logs) but on Homebrew clangd version 19.1.1. I'm a little confused about this 19.x release terminology as I'm new to looking at llvm's release structure, but does that mean I should be looking out for the next release version?

HighCommander4 commented 1 month ago

I've also encountered the aforementioned bug, where I talked about it here (with backtrace logs) but on Homebrew clangd version 19.1.1. I'm a little confused about this 19.x release terminology as I'm new to looking at llvm's release structure, but does that mean I should be looking out for the next release version?

Yes, 19.1.1 is affected as well.

The backport of this fix to the 19.x branch was just merged within the past day (https://github.com/llvm/llvm-project/pull/111318), so it will appear in the next dot release. According to this thread, that should be 19.1.2 around Oct 15.

Until then, I suggest using clangd 18. It can be obtained from https://github.com/clangd/clangd/releases/tag/18.1.3.

HighCommander4 commented 1 month ago

A 19.1.2 release is now up at https://github.com/clangd/clangd/releases/tag/19.1.2.