clang-tidy not respecting disabled checks

[Alex-EEE]

Please describe the problem. I'm trying to disable misc-definitions-in-headers Yet after doing so, I'm still seeing a warning flagged:

Logs

I[12:53:53.886] Apple clangd version 14.0.3 (clang-1403.0.22.14.1)
I[12:53:53.887] Features: mac+xpc
I[12:53:53.887] PID: 82019
I[12:53:53.887] Working directory: /Users/alex/work/edgeimpulse
I[12:53:53.887] argv[0]: /Library/Developer/CommandLineTools/usr/bin/clangd
I[12:53:53.887] Starting LSP over stdin/stdout
I[12:53:53.888] <-- initialize(0)
I[12:53:53.898] --> reply:initialize(0) 10 ms
I[12:53:53.900] <-- initialized
I[12:53:53.907] <-- textDocument/didOpen
I[12:53:53.908] --> textDocument/publishDiagnostics
I[12:53:53.917] Loaded compilation database from /Users/alex/work/edgeimpulse/unit-tests/build/compile_commands.json
I[12:53:53.919] ASTWorker building file /Users/alex/work/edgeimpulse/edge-impulse-sdk/dsp/numpy.hpp version 1 with command inferred from /Users/alex/work/edgeimpulse/edge-impulse-sdk/dsp/dct/fast-dct-fft.cpp
[/Users/alex/work/edgeimpulse/unit-tests/build/continuous-audio]
/Library/Developer/CommandLineTools/usr/bin/g++ --driver-mode=g++ -DEI_DSP_PARAMS_ALL=1 -DTF_LITE_DISABLE_X86_NEON=1 -D__GNUC_PYTHON__ -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../cppunit-1.15.1/include -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../cppunit-1.15.1/include/cppunit -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/. -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../.. -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/.. -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/include -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/classifier -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/porting -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/dsp -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/dsp/kissfft -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/dsp/dct -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/third_party/flatbuffers/include -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/third_party/gemmlowp -I/Users/alex/work/edgeimpulse/unit-tests/continuous-audio/../../edge-impulse-sdk/third_party/ruy -I/Users/alex/work/edgeimpulse/unit-tests/common-libs -I/Users/alex/work/edgeimpulse/unit-tests/common-libs/../.. -I/Users/alex/work/edgeimpulse/unit-tests/common-libs/../../edge-impulse-sdk/CMSIS/DSP/Include -I/Users/alex/work/edgeimpulse/unit-tests/common-libs/../../edge-impulse-sdk/CMSIS/DSP/PrivateInclude -I/Users/alex/work/edgeimpulse/unit-tests/common-libs/../../edge-impulse-sdk/CMSIS/Core/Include -g -fno-omit-frame-pointer -fsanitize=address -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -Werror -Wsign-compare -Wall -Wno-error=builtin-macro-redefined -c -std=gnu++11 -resource-dir=/Library/Developer/CommandLineTools/usr/lib/clang/14.0.3 -- /Users/alex/work/edgeimpulse/edge-impulse-sdk/dsp/numpy.hpp
I[12:53:53.921] --> textDocument/clangd.fileStatus
I[12:53:53.928] --> window/workDoneProgress/create(0)

System information I[12:53:53.886] Apple clangd version 14.0.3 (clang-1403.0.22.14.1) clangd extension version: 0.1.24 Operating system: MacOS

[Alex-EEE]

workaround : add/create .clangd file (I did at project level). Add something like:

Diagnostics:
  ClangTidy:
    Remove: misc-definitions-in-headers

[HighCommander4]

C_Cpp sounds like it may be the settings for Microsoft's vscode-cpptools plugin. Do you have this plugin installed? I wouldn't generally expect settings there to have an impact on clangd.

[Alex-EEE]

Yes, I do have that installed, but I have Intellisense disabled. I think I keep it around because of some debugging tools it adds?

[HighCommander4]

That's understandable.

My point is, I don't think there's a clangd bug here, since there isn't an expectation that clangd respects a different plugin's settings.

[Alex-EEE]

oooooh, ok, now I understand, that plugin ALSO includes clang tidy. Thanks for the clarification!