search

clangd / vscode-clangd

Visual Studio Code extension for clangd
https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.vscode-clangd
MIT License
592 stars 97 forks source link

Regression issue on the new 0.1.27 release. #599

Closed hokein closed 3 months ago

hokein commented 3 months ago

Steps:

  1. work in a cpp source file, and introduce some code that make clangd crashes.
  2. revert the change, and run clangd: restart language server command to restart clangd.

Now with 0.1.27, the restart command in 2) doesn't work -- I don't see a new instance of clangd starts. The https://github.com/clangd/vscode-clangd/pull/587 is a related change, @HighCommander4 .

HighCommander4 commented 3 months ago

Thanks for filing, I'll investigate.

HighCommander4 commented 3 months ago

Proposed fix: https://github.com/clangd/vscode-clangd/pull/601

Apologies for the regression.

HighCommander4 commented 3 months ago

I also filed https://github.com/clangd/vscode-clangd/issues/602 as a follow-up for adding some tests for the clangd.restart command to avoid accidentally introducing regressions like this in the future.

hokein commented 3 months ago

Confirm that v0.1.28 release works now. Thanks!