clangen / musikcube

a cross-platform, terminal-based music player, audio engine, metadata indexer, and server in c++
https://musikcube.com
BSD 3-Clause "New" or "Revised" License
4.2k stars 295 forks source link

.nsf/.hes/.vgm files can't be selected / played. #520

Open nPHYN1T3 opened 2 years ago

nPHYN1T3 commented 2 years ago

So I've been playing around with this (glad to see it's back...I used to use the old GUI version like 20 years ago) and noticed something odd. If I'm looking at the library on the artists panel I get some odd results for nsf files -but- I can see them and select/play them (-so the title is a tad misleading). However if I'm looking at Directory view and explicitly go to my folder where my .nsf/.hes/.vgm files are to play the folder displays as empty and nothing is selectable/playable.

I would expect if tags/meta data are not present the file names would be displayed (especially in dir view) so items can be selected.

Version 0.97.0 #5496aba9

clangen commented 2 years ago

Hi, thanks for the report!

I don't have any issues here browsing nsf files in directory view, but mine all seem to be well tagged. Would it be possible for you to show a screenshot of what exactly you see, and perhaps even supply one of the nsf files that isn't playable in directory view?

nPHYN1T3 commented 2 years ago

Well there are a few issues here. When in directory view I kinda expect files to go with that, not tags. This carries over to other things too like wav files that can't be tagged. You need to have a filename fallback at some point. Also in Musikcube as I said shows file info (names/tags/titles) but only in other views.

So for example under Artists the very first listed I have is "Gondamin" and then 20 tracks also named Gondamin. This is Bionic Commando for the NES. This all shows under Artist but if I switch to directory view and go to where that file is...empty/no listing.

0- 1-

I have never known you could change tags on vgn,nsf,hes files. I figured like various other formats it was created at creation time and destructive transcode or something similar was the only way to alter it. I've never seen or heard of a tagger for vgm,nfs,hes files so forgive my ignorance...but also please let me know how I can tag/change this because my files tags are insane and crap. On top of not being able to play untaggable formats due to the tag only display behavior even though my video game files clearly have tags they are useless to find anything to play thus file names are imperative to finding and selecting a track.

PythonTryHard commented 2 years ago

@nPHYN1T3 Can you upload a sample file to aid debugging?

nPHYN1T3 commented 2 years ago

In theory I can but at the same time what is the legality of such a thing heh. (Joking but serious) I am building a new version 0.98 atm and want to test something. Few tested file links for you to try below.

Another thing I've noticed on the new version is say on Faxanadu it shows the title now when set to Directory but some times it's on the same line as the item preceding it if the term is big but if I make the term smaller it drops to the next line as it should.

Did some more fooling around. If I make a folder on my Desktop/Game Trax and add the hes/nsf files when in directory view it shows as empty. I then tried GameTrax (same) and gametrax (still same) however if I back the view up to [Desktop] then all the tracks show. If I navigate to the actual directory where they are...empty?!

I've also added a folder for testing on my Desktop called VGMR. If I navigate to it despite being filled with vgm/vgz sub folders and zips the Directory listing on MusikCube shows it as empty. However if I go back up to [Desktop] it shows the exact same listings as if I went to Desktop/MUSIC. This is odd behavior as it kinda makes selecting anything other than / or $HOME silly if everything is "unstoppably recursive." However root or explicit folder it ignores any video game formats unless you are in other views.

https://fi.zophar.net/soundfiles/turbografx-16-hes/dungeon-explorer/Dungeon%20Explorer%20%28EMU%29.zophar.zip

https://fi.zophar.net/soundfiles/turbografx-16-hes/dragons-curse/Dragon%27s%20Curse%20%28EMU%29.zophar.zip

https://fi.zophar.net/soundfiles/nintendo-nes-nsf/faxanadu/Faxanadu%20%28EMU%29.zophar.zip

https://fi.zophar.net/soundfiles/nintendo-nes-nsf/shadowgate/Shadowgate%20%28EMU%29.zophar.zip