clangen / musikcube

a cross-platform, terminal-based music player, audio engine, metadata indexer, and server in c++
https://musikcube.com
BSD 3-Clause "New" or "Revised" License
4.08k stars 295 forks source link

Binaries aren't linked with libFLAC.so, libogg.so, libvorbis.so but script/build-vendor-libraries.sh lists them #638

Closed yurivict closed 7 months ago

yurivict commented 9 months ago

These libraries are only listed in the shell script, and configure doesn't look for them, and build doesn't link binaries with them.

Are these libraries real dependencies of musikube?

These libraries were flagged by the FreeBSD ports framework as potentially unused dependencies:

Warning: you might not need LIB_DEPENDS on libboost_system.so
Warning: you might not need LIB_DEPENDS on libFLAC.so
Warning: you might not need LIB_DEPENDS on libogg.so
Warning: you might not need LIB_DEPENDS on libvorbis.so
clangen commented 9 months ago

Yep, good call-out. These libraries used to be required, but are not any longer. You should be able to remove them from the dependency list without issues.

clangen commented 7 months ago

Closing this ticket, please re-open if you have any additional questions. :)