clap-rs / clap

A full featured, fast Command Line Argument Parser for Rust
docs.rs/clap
Apache License 2.0
13.66k stars 1.02k forks source link

build delta-inspect raise could not find `delta_datafusion` in the crate root #5400

Closed dgouyette closed 3 months ago

dgouyette commented 3 months ago

Please complete the following tasks

Rust Version

stable-aarch64-apple-darwin unchanged - rustc 1.76.0 (07dca489a 2024-02-04)

Clap Version

3.2.23

Minimal reproducible code

cd delta-inspect

cargo build

will raise :

error[E0432]: unresolved import `crate::delta_datafusion`
 --> crates/core/src/operations/transaction/conflict_checker.rs:5:12
  |
5 | use crate::delta_datafusion::DataFusionMixins;
  |            ^^^^^^^^^^^^^^^^ could not find `delta_datafusion` in the crate root

error[E0700]: hidden type for `impl Iterator<Item = actions::Add>` captures lifetime that does not appear in bounds
   --> crates/core/src/operations/transaction/conflict_checker.rs:196:9
    |
109 | impl<'a> TransactionInfo<'a> {
    |      -- hidden type `impl Iterator<Item = actions::Add> + 'a` captures the lifetime `'a` as defined here
...
195 |     pub fn read_files(&self) -> Result<impl Iterator<Item = Add>, CommitConflictError> {
    |                                        ------------------------- opaque type defined here
196 |         Ok(self.read_snapshot.file_actions().unwrap().into_iter())
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Some errors have detailed explanations: E0432, E0700.
For more information about an error, try `rustc --explain E0432`.

Steps to reproduce the bug with the above code

cd delta-inspect

cargo build

Actual Behaviour

build is failing

Expected Behaviour

build successful

Additional Context

in

path = "../crates/deltalake"
version = "0"
features = ["azure", "gcs"]

it misses datafusion

I can provide a PR if needed

Debug Output

No response

epage commented 3 months ago

Is there a reason you opened this issue on the clap repo?

dgouyette commented 3 months ago

😞