Closed pzmarzly closed 4 weeks ago
Re: linter error. Commit subject max line length of 50 is brutal, even feat(complete): Autocomplete visible_alias powershell
doesn't fit (53 chars).
I fixed the linter issues, and implemented support for all shells.
@epage is there something you'd like me to do here, or something I can do to make it easier for you to review it? Many thanks.
Thanks!
Fixes #4265
Closes #5412
This PR picks up work from #5412 to get it to a merge-able state.
I'm splitting the work into 2 standalone commits (all tests pass on both of them), to make it easier to review. I leave it up to you whether to merge them in or squash them into one.
Commit 1. Fixing the iteration over
all_subcommands
inzsh.rs
. We deduplicate values on(sc_name, bin_name)
keys, but then only iterate onbin_name
. This doesn't cause problems now, since all bin names seem to be unique. However, without fixing this, the second commit would have started generating duplicated functions with same names.Commit 2. Starting to generate autocompletions for aliased subcommands. This is taking the code from #5412 and updating it to latest changes.
Testing the change
Adapting the test code from #4265's first comment:
After making this change to clap_complete: