clap-rs / clap

A full featured, fast Command Line Argument Parser for Rust
docs.rs/clap
Apache License 2.0
13.64k stars 1.02k forks source link

feat(clap_complete): add native completion support for elvish #5544

Open shannmu opened 1 week ago

shannmu commented 1 week ago

Closes https://github.com/clap-rs/clap/issues/3919

epage commented 1 week ago

related issue: https://github.com/clap-rs/clap/issues/3919

If this isn't closing out the issue, what is left?

shannmu commented 1 week ago

If this isn't closing out the issue, what is left?

I don't understand what you mean. Adding the related issue is for easier tracking :)

epage commented 1 week ago

I don't understand what you mean. Adding the related issue is for easier tracking :)

The language used doesn't make this sound like the issue is fully resolved by this PR, so I was asking what is left. In fact, there are standardized terms for fully resolving an issue as Github has support for keywords to link PRs to issues (not just backlinks) and even auto-close issues.