clappr / clappr-level-selector-plugin

Clappr Level Selector Plugin
MIT License
76 stars 56 forks source link

Buffering animations sometimes never ends #22

Closed ariselseng closed 8 years ago

ariselseng commented 8 years ago

Hi, I have a problem with this plugin where the buffering animations sometimes never goes away when the video is ready and playing. I have only tested with live stream.

I have only experienced the problem on Firefox (using linux).

Test url: http://rawgit.com/cowai/b14e3825604c6e612120/raw/a334f3a5774a5313a2447d8c12a10ad95f078406/clappr-live-icon-with-dvr-and-levelselector-test.html

leandromoreira commented 8 years ago

Is it easy to reproduce this?

ariselseng commented 8 years ago

Hi, Yes, just try to skip around in the timeline. For me it happens almost every time I skip.

leandromoreira commented 8 years ago

Thanks, are you using hls.js or forcing flashls?

ariselseng commented 8 years ago

Without this plugin, it never happens though.

leandromoreira commented 8 years ago

O.O

ariselseng commented 8 years ago

You can see all the options I use here: http://rawgit.com/cowai/b14e3825604c6e612120/raw/a334f3a5774a5313a2447d8c12a10ad95f078406/clappr-live-icon-with-dvr-and-levelselector-test.html

hls.js is being used.

leandromoreira commented 8 years ago

I think I know what it is https://github.com/clappr/clappr-level-selector-plugin/blob/master/src/main.js#L29 we may need to check if core.isReady to call it directly otherwise listen to the event, I 'll test that later though.

ariselseng commented 8 years ago

I dont get this error anymore. Is it fixed?

leandromoreira commented 8 years ago

We fixed a lots of things on clappr's side (mostly buffering), i think it's reasonable! can we close this?

ariselseng commented 8 years ago

Yes as I dont experience the problem on latest clappr I think so yes :)

leandromoreira commented 8 years ago

lol thanks so much @cowai