Shows to delete - Githubissues

Protektor-Desura commented 2 years ago

I wish there was a way to say only delete the following shows episodes after they are watched by everyone but keep the rest. Like there some cop and drama shows we will never watch again, but other shows like Game of Thrones that we will go back and watch again,

It would almost be like wanting to invert favorites. Current shows we are watching but won't ever watch again so don't keep those episodes once everyone has watched them.

WolfgangDpunkt commented 2 years ago

I think there are already two simple ways to do this:

You mark the special shows you want to keep as favorites and make sure that deleting favorites is disabled in the configuration.
Or you divide your shows into two libraries: "not so important shows" and "important shows". For the second library, just disable the tool (or whitelist only the first library).

terrelsa13 commented 2 years ago

My goal is to keep things as simple as possible and give the right configuration options to cover most use cases.

@Protektor-Desura with multiple users things can quickly get messy. In order to do what you are asking for, the script would have to go thru every TV series and have the user chose the following for each of them "Episodes in TV Series XYZ will be deleted after the following users watch them: Any/All/User1/User2/User#/etc..." The same would have to be done for all movies.

@WolfgangDpunkt is correct with both options. The second will be the easiest to manage long term because you would not need to favorite new TV shows as they are grabbed in the future. Just specify a new folder/library in Emby/Jellyfin and have Sonarr (or whatever program) place specific shows in the new folder/library. Don't forget to move existing shows into the new folder/library so they are also preserved. Then if you are using the "blacklisting" method do not choose the new folder library or if you are using the "whitelisting" method choose the new folder/library.

Protektor-Desura commented 2 years ago

I think there are already two simple ways to do this:

* You mark the special shows you want to keep as favorites and make sure that deleting favorites is disabled in the
   configuration.

* Or you divide your shows into two libraries: "not so important shows" and "important shows".
  For the second library, just disable the tool (or whitelist only the first library).

The problem with multiple libraries is requesting software like Ombi and adding new shows with import lists like from Trakt and IMDB, etc in Sonarr and Radarr. You quickly end up with things in the wrong library once you have multiple TV libraries and multiple Movie libraries. Moving shows and movies around once they are setup is a pain if you ask me and inevitably you end up missing one and cursing later because it got deleted or other issues.

Remember Ombi only supports 2 TV libraries, anime and everything else. Ombi only supports 1 Movie library.

terrelsa13 commented 2 years ago

Looks like importing lists into Sonarr/Radarr allow you to choose the library those TV shows/movies go into. May need to import one list for media that is okay to delete and another for media to keep. Point the respective lists to the respective libraries.

I do not use Ombi and do not know a whole lot about it, but at the surface, this sounds like an Ombi limitation. The other media management tools support as many libraries as you need. I wonder why is Ombi imposing library limits?

If the multiple libraries option will not work for you; using favorites is the next best option. Set keep_favorites_episode=2. All of the monitored users will need to set the TV show/season/episodes they want to keep as a favorite. As long as at least one user has it set as favorite it will not be deleted. After a user watches a TV show/season/episode they will need to unfavorite it. Once no user has it set as a favorite, the media item it will be deleted.

Protektor-Desura commented 2 years ago

Looks like importing lists into Sonarr/Radarr allow you to choose the library those TV shows/movies go into. May need to import one list for media that is okay to delete and another for media to keep. Point the respective lists to the respective libraries.

You can't say put some from this list in this library and others from that list to a different library. That is my point. I don't keep for example cop shows and most dramas, but I do keep most sci-fi and fantasy and really really well done drama like Mad Men. There is no way to automate this and thus the problem.

I do not use Ombi and do not know a whole lot about it, but at the surface, this sounds like an Ombi limitation. The other media management tools support as many libraries as you need. I wonder why is Ombi imposing library limits?

Because you need to know what directory/library to put new requested shows and if you have no idea other than it is a TV show or Movie how do you know which of 5 TV libraries to automatically put it in? There isn't really a way to do that. How do you know that say Cleaner coming out on Fox, which isn't even out yet which TV library automatically it should go in to? That's the problem.

If the multiple libraries option will not work for you; using favorites is the next best option. Set keep_favorites_episode=2. All of the monitored users will need to set the TV show/season/episodes they want to keep as a favorite. As long as at least one user has it set as favorite it will not be deleted. After a user watches a TV show/season/episode they will need to unfavorite it. Once no user has it set as a favorite, the media item it will be deleted.

This is the problem with trying to have multiple TV libraries, knowing automatically where to put things. This is where a simple web interface that reads the libraries of shows and let you check which to auto delete from and which to keep, would make life way way simpler for most people. Then when a new show is added, it sees that it doesn't have a setting, and asks the admin what do with newly added shows.

If you don't want to do it. That is fine. But there are logical reasons for asking for this feature.

terrelsa13 commented 2 years ago

This is the problem with trying to have multiple TV libraries, knowing automatically where to put things. This is where a simple web interface that reads the libraries of shows and let you check which to auto delete from and which to keep, would make life way way simpler for most people. Then when a new show is added, it sees that it doesn't have a setting, and asks the admin what do with newly added shows.

You can achieve what you are looking for by setting keep_favorites_episode=2 + keep_favorites_movie=2 and teaching the users to favorite TV shows, seasons, episodes, or movies they want to keep. This approach allows the individual users control (down to the episode level) over what they want to keep or delete. Which in my opinion is better than having to go into Emby/Jellyfin anytime a new TV show/movie is grabbed to check a box or having the users contact me (the admin) to go into Emby/Jellyfin to check a box every time someone changes their mind on what TV Shows/movies they want to keep.

If you don't want to do it. That is fine. But there are logical reasons for asking for this feature.

As I mentioned on reddit I have no plans or time to make a UI for this. If I did make a UI, it would be for Emby as I do not use Jellyfin (I have thought about it, but have not pulled the trigger). That means this feature request would require going thru every TV series and movie on the command line and having to choose how each one is treated. Seems like it would be overwhelming during the configuration building process.

terrelsa13 commented 2 years ago

@Protektor-Desura

Wrapping up work on deleting or keep items based on specified blacktags or whitetags associated to a media item. There is a BETA branch here where this can be used and tested.

This is not backwards compatible with the existing config. It is recommend to either make a backup copy of the existing config or run the BETA in a completely separate folder.

During setup the script will prompt for blacktags to be used to delete media items after they are watched and/or whitetags to be used to keep media items after they are watched. Leave a tag empty if not wanting to use one or both.

Additional detail on how tagging works can be found here.

*Edit - Beta branch updated to allow blacktagged media items to only be deleted either after ALL monitored users have watched it OR after ANY monitored user has watched it.

terrelsa13 commented 2 years ago

This is now part of my trunk. This issue can now be closed.

clara-j / media_cleaner

Shows to delete #29