claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

Add new option `consul_ssl_enabled` and parameters to configure it #105

Closed wyardley closed 6 years ago

wyardley commented 6 years ago

Here's a feature we have in our local fork (let me know if there's a different way to accomplish this)

It also adds test coverage for consul_template::config. Even though it's not a private class, the way it's configured now is difficult (or even impossible) to test separately, so I ended up putting the tests in a separate describe block in the main class config (this would also make some proposed changes (see below) easier to handle).

If there's interest, I could work on making this Puppet 4+ only, adding data types, and / or making some of the classes explicitly private.

craigwatson commented 6 years ago

Thanks :)