claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

Ensure resource ordering, regardless of boolean states. #11

Closed joshsouza closed 9 years ago

joshsouza commented 9 years ago

User/Group ordering causes errors rarely without this, due to the semi-random manner in which Puppet orders things. If the group gets created before the user, the user create will fail. Can't put direct require/before tags in the entities though, due to the if statements on management, thus we just use resource ordering. I added in the File bit so that the file resource that depends on the user/group ensures they exist first (that can also cause ordering issues).

gdhbashton commented 9 years ago

Nice one - and the syntax is both unusual and pretty :)

aj-jester commented 9 years ago

Unfortunately this is breaking because its causing dependency cycles with other user and group resources elsewhere.

In my opinion this is not needed. We do the same thing over at puppet-consul module and it works fine without this extra precaution.

Issue opened: https://github.com/gdhbashton/puppet-consul_template/issues/18