search

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

GitHub module style #111

Closed sts closed 6 years ago

sts commented 6 years ago

Adopt module structure to the Github internal fork. Closes #100

The code was tested on Debian so far and worked, also added a more detailed changelog entry to outline the changes.

wyardley commented 6 years ago

@sts Thanks for doing this, much appreciated, as we rely on this functionality as well (though rebasing #100 is going to be a lot of fun). 👍 Put a couple comments inline, though I don't think they're super important.

wyardley commented 6 years ago

@ross FYI, this attempts to bring the changes from your fork back upstream. Also proposing some major changes in #108 (not yet merged as of time of writing). Would love if you have any feedback.