Feature request: consul_template::watch should take a variables hash

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp

Apache License 2.0

30 stars 89 forks source link

Feature request: consul_template::watch should take a variables hash #22

Closed madAndroid closed 9 years ago

madAndroid commented 9 years ago

Hi,

Firstly, great module :) A feature request: would you consider adding a variables hash to the consul_template::watch define? This would allow the (puppet) templating of the (consul) template more appropriately; for example to be able to use the same template for multiple consul_template::watch instances.

If you think this would be a good addition, I'll put a PR together

Thanks, Andrew

gdhbashton commented 9 years ago

Hey Andrew - always good to hear from you!

Re-use is almost always desirable so yes I'd love to see a PR to improve watch :)

madAndroid commented 9 years ago

Hey Gavin :) awesome, I'll put something together... cheers! :)

madAndroid commented 9 years ago

Fixed with #23