search

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

Add data_dir, manage_{user,group} as optional parameters in init.pp #25

Closed nhandler closed 9 years ago

nhandler commented 9 years ago

consul_template::install requires some variables to work properly. However, the class takes no parameters. By adding them as optional parameters in init.pp, they can be passed in directly or via Hiera.

Currently, there are no tests for this class. A simple 'it { is_expected.to compile }' will unearth the problem. The trickier part of writing a test is that the class operates under the assumption that consul_template will be executed first, and that consul_template will include consul_template::install. This makes it difficult to write a spec that directly tests consul_template::install.

gdhbashton commented 9 years ago

Ooh lovely - if you're going to submit a PR full of tests then you're my favourite person :)