search

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

Use directory (instead of single file) for configuration #27

Closed bgirardeau closed 8 years ago

bgirardeau commented 9 years ago

This makes consul-template read its configuration files from a directory instead of just the config.json file. The only change in existing behavior is the exact path of the config file (which was moved to a subdirectory).

The use case for this is letting configuration be added independently of this module. Specifically it's useful to allow another process to provide the Vault address and token.

gdhbashton commented 9 years ago

Hi, in respect of the Vault configuration, can you comment on the changes I made to master a month or so ago? https://github.com/gdhbashton/puppet-consul_template/issues/24

If there's no need to add more config, I'd prefer to keep things simple :)

bgirardeau commented 9 years ago

Those options work well for many cases, but I'd like to use a separate (consul-template) process to configure Vault's address and token dynamically, which might change independently of Puppet running. Reading from a configuration directory makes this easier without complicating this module.

gdhbashton commented 8 years ago

Thank you! :)