search

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

Auto upgrade #34

Closed sw0x2A closed 8 years ago

sw0x2A commented 8 years ago

Following changes let Puppet download a new release and installs the binary when the version variable has been changed. Furthermore, since release 0.11.0 consul-template comes as zip rather than a tar.gz, so I changed download url and how to extract it.

gdhbashton commented 8 years ago

Hey Stefan,

Thanks for the PR! Apologies for the delay - I'm just back from holiday..

Can I ask that you rebase against current master? I pushed some changes last Friday, just a couple of hours before consul-template 0.11.0 was released, which set the default install version to 0.10.0 - so your PR is currently merge conflicting.

Further, I notice that your changes mean that only versions 0.11.0 and newer can be supported, and I'm not in favour of that - I would like to preserve compatibility for users who choose (or must) pin to a specific older version of consul-template - so I'd need to see some conditional logic to switch behaviour for .tar.gz or .zip with versioncmp()

gdhbashton commented 8 years ago

Superceded by #36

sw0x2A commented 8 years ago

The other PR doesn't fix the issue that a newer version is not automatically upgraded but require the staging file and consul-template binary to be removed manually so Puppet installs the new version. Interested in a PR with only this change?

gdhbashton commented 8 years ago

Yup sure :)