[WIP] Miscellaneous improvements (support watch content, add tests, etc.)

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp

Apache License 2.0

30 stars 89 forks source link

[WIP] Miscellaneous improvements (support watch content, add tests, etc.) #40

Closed chrismwendt closed 8 years ago

chrismwendt commented 8 years ago

This is labeled as a WIP since a few bugs were recently found and fixed.

This PR integrates various improvements made by @grantr, including:

Add support for passing in content directly to a watch
Avoid out-of-favor shared params
Use a readable .erb template for watches instead of inline content
Add tests

We would like to use this module if possible, and I hope these changes benefit anyone else using it too.

gdhbashton commented 8 years ago

Oh my! This is less a patch as a complete rewrite, and it's great to see all those lovely tests.

Can you let me know when you feel it's less WIP and more 'ready to merge' ? e.g. the expectation of a Ubuntu system with a consul-template package in apt, rather than downloading from upstream.

I haven't had time to actually review the changes but at a glance I see all the docs for the parameters in init.pp have disappeared, but not appeared anywhere else - is that expected?

chrismwendt commented 8 years ago

@grantr and I reviewed the changes once more and decided that the only obviously beneficial parts to this PR are the tests. I attempted to modify them to work with this version of the code, but the base code is just so different that it's probably easier to write new ones from scratch.

I'm going to close this PR since there is no expectation for it to be merged at this time.