search

claranet / puppet-consul_template

A Puppet module to manage the config and jobs of Consul Template from Hashicorp
Apache License 2.0
30 stars 89 forks source link

Update the version of concat to use, does not work with v1.0.0 #5

Closed codesplicer closed 9 years ago

codesplicer commented 9 years ago

Tested with concat v1.0.0 and the module failed to render config.json correctly. Newer version of concat works fine.

gdhbashton commented 9 years ago

Cool - can you provide an example of the incorrect JSON to help any future searches?

codesplicer commented 9 years ago

Well it doesn't even render the JSON file, the puppet run fails with:

==> default: Warning: Scope(Concat::Fragment[header]): Could not look up qualified variable 'concat::setup::root_group'; class concat::setup has not been evaluated
==> default: Warning: Scope(Concat::Fragment[header]): Could not look up qualified variable 'concat::setup::concatdir'; class concat::setup has not been evaluated
==> default: Warning: Scope(Concat[consul-template/config.json]): Could not look up qualified variable 'concat::setup::root_group'; class concat::setup has not been evaluated

and

==> default: Error: Could not set 'present' on ensure: No such file or directory - /consul-template_config.json/fragments/00_header20150224-8401-1azrlg0.lock at 66:/tmp/vagrant-puppet/modules-2a0d2038743e6c4355f99d1ad4e81937/concat/manifests/fragment.pp
==> default: Error: Could not set 'present' on ensure: No such file or directory - /consul-template_config.json/fragments/00_header20150224-8401-1azrlg0.lock at 66:/tmp/vagrant-puppet/modules-2a0d2038743e6c4355f99d1ad4e81937/concat/manifests/fragment.pp
==> default: Wrapped exception:
==> default: No such file or directory - /consul-template_config.json/fragments/00_header20150224-8401-1azrlg0.lock
==> default: Error: /Stage[main]/Consul_template::Config/Concat::Fragment[header]/File[/consul-template_config.json/fragments/00_header]/ensure: change from absent to present failed: Could not set 'present' on ensure: No such file or directory - /consul-template_config.json/fragments/00_header20150224-8401-1azrlg0.lock at 66:/tmp/vagrant-puppet/modules-2a0d2038743e6c4355f99d1ad4e81937/concat/manifests/fragment.pp

Seems the newer concat module fixes a bug.

gdhbashton commented 9 years ago

Ah perfect - that's the stuff Google loves :) Thank you for the contribution!