Update default value of reserved_concurrent_executions to -1

claranet / terraform-aws-lambda

Terraform module for AWS Lambda functions

MIT License

157 stars 127 forks source link

Update default value of reserved_concurrent_executions to -1 #39

Closed jeohist closed 5 years ago

jeohist commented 5 years ago

As https://github.com/terraform-providers/terraform-provider-aws/pull/3806 has been merged into the Terraform AWS Provider 2.0, the current default value of this module will effectively mean no Lambda invocations will be handled. By setting the default value to -1 instead of 0, we return to the original unrestricted value.

Rowern commented 5 years ago

Yes, please, this made for a really weird deploy day for us...

raymondbutcher commented 5 years ago

Hi, sorry I didn't see this sooner.

I think we should add an AWS provider restriction for >= 2.0.0 to aws.tf when doing this.

raymondbutcher commented 5 years ago

Just looking into this myself and I don't think you can really pin a provider version in a module without also specifying other fields like region, credentials, etc. I'm currently testing how this works with different versions and will report back.

raymondbutcher commented 5 years ago

How the AWS provider works:

The old provider checks for > 0 when deciding if it should set a value or be unlimited.
- -1 is unlimited
- 0 is unlimited
The new provider checks for >= 0 when deciding if it should set a value or be unlimited.
- -1 is unlimited
- 0 sets a value of 0 which disables the function

So setting it to -1 has no downside. I'll merge and release this, thanks!

raymondbutcher commented 5 years ago

This is in v0.11.3