search

claranet / terraform-aws-lambda

Terraform module for AWS Lambda functions
MIT License
157 stars 127 forks source link

Working with terraform 0.12 #47

Closed naps62 closed 5 years ago

naps62 commented 5 years ago

I was trying to make this work with terraform 0.12, which we're currently using. We upgraded our whole codebase, and I just now noticed that I can't produce changes to the few places where I'm using this package, due to errors

So I patched the code as a quick-fix for our side, but am also opening this here so it can be discussed as a final solution

The current changes are backwards incompatible with terraform 0.11, so I'm not sure if that's acceptable. But my terraform skills weren't good enough to produce a compatible solution in short time.

Happy to take suggestions (or alternative PRs if this one is too bad)

There were also a couple of changes I had to make that didn't seem related. I'm not sure if those are due to 0.12's different behaviour, due to recent commits on this repo that I wasn't using yet (I was on a commit from a few months ago), or just mistakes on my part. I'll comment those individual parts of the PR

raymondbutcher commented 5 years ago

Hi @naps62. Thanks for the PR. I used it as a bit of a reference and went further in #49 . I'll do a bit more testing + review and merge that one. Cheers!

naps62 commented 5 years ago

Thanks. I'll subscribe to that PR then