search

claranet / terraform-aws-lambda

Terraform module for AWS Lambda functions
MIT License
157 stars 127 forks source link

Document `attach_policy` #54

Open calve opened 5 years ago

calve commented 5 years ago

Looking at the module behaviour and the code, it's looks like user needs to set attach_policy to actually create and attach the additonal policy.

lorengordon commented 5 years ago

@calve make sure you are using the current version of the module. attach_policy is no longer a valid variable, as of v1.0.0...

calve commented 5 years ago

Indeed im still on terraform 0.11 se I'm not using the last release. Maybe we should make clear this variable il mandatory for pre-0.12 but is deprecated otherwise ?

Le 9 juillet 2019 16:41:05 GMT+02:00, Loren Gordon notifications@github.com a écrit :

@calve make sure you are using the current version of the module. attach_policy is no longer a valid variable, as of v1.0.0...

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/claranet/terraform-aws-lambda/pull/54#issuecomment-509670842

lorengordon commented 5 years ago

You might want to just reference the readme from the version of the module that you are using...

lorengordon commented 5 years ago

For example: https://github.com/claranet/terraform-aws-lambda/blob/v0.12.0/README.md

calve commented 5 years ago

I understand you. The front README don't state any interface changes beside the one induced by the Terraform upgrade. The reader may thinks that both 0.x and 1.x versions have the usage but have no clue there used to be mandatory attach_ booleans. Terraform does not output errors since it does not try to attach anythink.

I'll suggest to reference the 0.12.0 README in the version compatibility table, but I'm not sure we can avoid hardcoding a github.com link since GFM does not suport branch relatives links (https://github.com/github/markup/issues/84#issuecomment-3223278), or at least mention the module interface got updated.

Otherwise feel free to close this MR :)