search

claranet / terraform-signalfx-detectors

Collection of terraform modules for SignalFx detectors.
Mozilla Public License 2.0
22 stars 31 forks source link

[BUG] Detector fivexx_http_response - integration_aws-elasticsearch - Different metric names #516

Closed nicolas-dsk-claranet closed 7 months ago

nicolas-dsk-claranet commented 7 months ago

What is the module? ntegration_aws-elasticsearch

What is the detector? fivexx_http_response

Describe the bug The metric name used as a divisor within that detector is 'OpenSearchRequests'. However, as specified in the AWS documentation, the metric name was 'ElasticsearchRequests'. I suggest to use the same logic as in 'fourxx_http_response' detector, pass the divisor to '2xx'

To Reproduce AWS env have a OpenSearch, still with the 'ElasticsearchRequests' name for example

pdecat commented 7 months ago

This is done intentionally and as recommended by AWS documentation:

5xx alarms >= 10% of OpenSearchRequests

See also this link that is mentioned here.

Edit: maybe worth adding the link to the 5xx detector too.