search

clarete / forbiddenfruit

Patch built-in python objects
https://clarete.li/forbiddenfruit/
GNU General Public License v3.0
826 stars 52 forks source link

Is the C ffruit module needed? #9

Closed orf closed 4 years ago

orf commented 10 years ago

Is the C ffruit module required for the actual module to work? I can't see it referenced outside of the tests folder, and including it in the setup.py means that Windows users can't install the module without a C compiler.

clarete commented 10 years ago

Hi @orf. Sorry about that, you're totally right. We don't really need that module compiling all the time. Just for tests. However, I'm not sure when I'll tackle this issue but I'd be happy to accept a patch to the setup.py file.

orf commented 10 years ago

I'm not actually sure how to do this, ideally the extension should be optional and only installed if a compiler is available. I've looked at a few projects (like thrift) that do this but I can't see a standard way to make it do this. I will take another look in a week or so when I have some free time.