search

clarete / hackernews.el

Hacker News client for Emacs
GNU General Public License v3.0
249 stars 26 forks source link

add customization and fix keybinding #12

Closed LouisKottmann closed 10 years ago

LouisKottmann commented 10 years ago

Hello,

This fixes the q keybinding and all subsequent keybindings that may be added. The if in elisp is like a tertiary operator. If you don't use progn, the second line is considered the else clause. So it used to say: if there's a hackernews-map then add the g keybinding to it, otherwise add the q one. In fact, if you don't plan on having an else clause, I believe you can use when instead of if.

It also adds the possibility for users to customize the color of the links in the hackernews buffer. I have a light theme and green simply was unreadable.

Have a nice day! Louis "Baboon" Kottmann

clarete commented 10 years ago

Awesome patch!!! Thank you for the contribution, I loved the color customization!

LouisKottmann commented 10 years ago

:yum:

clarete commented 10 years ago

I tried to make an upload to marmalade but I've got an error :/

LouisKottmann commented 10 years ago

What's the error? Marmalade is unfortunately not renowned for its stability..

clarete commented 10 years ago

It might be related to the way I'm packing the tar file too.

here we go:

Express
500 TypeError: Cannot call method 'match' of undefined
at Function. (/home/vagrant/node_modules/marmalade/lib/server/ui.js:468:43)
at next (/home/vagrant/node_modules/marmalade/node_modules/step/lib/step.js:51:23)
at Step (/home/vagrant/node_modules/marmalade/node_modules/step/lib/step.js:122:3)
at /home/vagrant/node_modules/marmalade/lib/server/ui.js:462:9
at callbacks (/home/vagrant/node_modules/marmalade/node_modules/express/lib/router/index.js:272:11)
at param (/home/vagrant/node_modules/marmalade/node_modules/express/lib/router/index.js:246:11)
at pass (/home/vagrant/node_modules/marmalade/node_modules/express/lib/router/index.js:253:5)
at Router._dispatch (/home/vagrant/node_modules/marmalade/node_modules/express/lib/router/index.js:280:4)
at Object.handle (/home/vagrant/node_modules/marmalade/node_modules/express/lib/router/index.js:45:10)
at next (/home/vagrant/node_modules/marmalade/node_modules/connect/lib/http.js:203:15)
LouisKottmann commented 10 years ago

That doesn't seem related to this PR, maybe a change in how marmalade works?

clarete commented 10 years ago

hehe, you're surely right! I'm not the first to hit this issue as well: Let's follow the discussion here: https://github.com/nicferrier/marmalade/issues/73

Thanks!

LouisKottmann commented 10 years ago

Thankfully nic is always on the lookout ;)

swsnr commented 10 years ago

@clarete Have a look at https://github.com/lunaryorn/marmalade-upload. It lets you upload packages from the command line via the Marmalade API.

clarete commented 10 years ago

Thanks @lunaryorn I just tried it out and it actually works! Here we go! version 0.2.1 is out. Thanks guys!

http://marmalade-repo.org/packages/hackernews