Closed basil-conto closed 6 years ago
Another to-do before merging is to update the README
.
I tried it out and it works great! The ability to fetch the other hackernews feeds plus the detailed progress reporter are seemingly small but great improvements. I also don't see any problems with the other points you mentioned.
Same here, I didn't have the time to do any meaningful comment but I saw it running and you got me at the progress! That's amazing!!! Don't you just want push access to the project? So I don't block your progress? @basil-conto
I'm just on a time crunch at a other project and that's not your first very valuable contrib!!!
@accidentalrebel @clarete Thank you very much both for testing the changes and the positive feedback.
@clarete I would be very honoured by being granted push access, especially if it means sharing your workload. Either way, however, I would feel the need to seek some form of confirmation before merging anything in the future. :)
Done! Just invited you to get push access @basil-conto! I'm honored that you think the project is worth investing your time!! Can't wait to see this pushed to master! hackernews.el will get a new version soon after a while!!
@clarete Thank you very much. :) It's a pleasure using and hacking on this package.
I'll get back to this PR later tonight (UTC). In the meantime, is there anything I should be aware of re: MELPA? I'm asking because I've never had to deal with it before.
@clarete I've done the following in preparation for the release:
Makefile
aesthetics0.4.0
README
:package-version
keywords to new defcustom
optionsv0.4.0
tagI will merge basil-conto:dev
with clarete:master
on Friday or following confirmation, whichever comes first.
I don't really know about the melpa thing either, IIRC I only uploaded it to marmalade. Doing some digging, I found this: https://github.com/melpa/melpa/blob/master/recipes/hackernews Which looks like what makes it available there.
When it comes to a "new release", I think it could be nice to maybe separate all the version number changes in the commit that will be tagged as that version. What do you think?
Also, given the extent of your contributions, please include your name as an author too!
\o/ That's very exciting!
The rest of the PR looks epic, thanks for referencing the Emacs Documentation in your changes! I feel like parts of it were talking to me! lol
‘Keywords’
(...)
The name of this field is unfortunate, since people often assume
it is the place to write arbitrary keywords that describe their
package, rather than just the relevant Finder keywords.
One correction, I missed that the last commit does pretty much what I suggested! I'm 👍 with the PR after the author change! \o/
I only uploaded it to marmalade
Ah, I always forget about Marmalade and mix it up with MELPA. Indeed, the latter gets updated automatically by tracking the version-controlled repository, whereas the former requires manual upload. It looks like https://marmalade-repo.org/ is stagnating, though.
the last commit does pretty much what I suggested
Great, was just about to ask. :)
I feel like parts of it were talking to me
I always get that feeling when it comes to GNU/FSF documentation. :)
I'm 👍 with the PR after the author change
OK, will do that, rebase and release. Thanks everyone for all the quick feedback and support. :)
I just updated from Melpa and everything works. Good job on this new update!
@accidentalrebel Thanks! Already found and fixed the first bug after seeing your comment. :)
Summary of user-visible changes
I have tried to make the commits as atomic / self-contained / explanatory as possible, so I recommend reviewing each one in turn. I decided against creating a string of smaller PRs as I find the changes herein to nicely sum up to a new major/minor package version. Nevertheless, I would be more than happy to oblige smaller PRs.
hackernews-mode
derived fromspecial-mode
.help-echo
button property (i.e. the button's URL) when moving around.Breaking changes
defvar
hackernews-top-story-limit
to more general-purposedefcustom
hackernews-items-per-page
.hackernews-map
tohackernews-mode-map
as per major mode conventions.hackernews-mode-map
,g
is now bound tohackernews-reload
instead ofhackernews
.switch-to-buffer
to higher-level and more customisablepop-to-buffer
, which prefers switching to another window instead of reusing the current one.pop-to-buffer
usesdisplay-buffer
as a subroutine, so users can customisedisplay-buffer
to openhackernews
buffers as desired, e.g. viasame-window-buffer-names
.hackernews-load-more-stories
not moving point.hackernews-preserve-point
to revert to old behaviour.Before merging
:package-version
keywords to alldefcustom
s accordingly.define-obsolete-variable-alias
es accordingly forhackernews-top-story-limit
->hackernews-items-per-page
andhackernews-map
->hackernews-mode-map
.