search

clarete / hackernews.el

Hacker News client for Emacs
GNU General Public License v3.0
248 stars 26 forks source link

Delete hard-coded link foreground #34

Closed novakboskov closed 6 years ago

novakboskov commented 6 years ago

Perhaps it is not the wisest decision to hard-code color of the link foreground because given green looks too bright for lighter themes such as spacemacs-light for example.

Otherwise, great package. Thank you for that!

basil-conto commented 6 years ago

I'm in favour of this change for two reasons:

  1. It is always best to reuse standard faces, such as link in this case, to maximise the chances of the face looking acceptable.
  2. I already remove the green foreground in my own configuration. :)

@clarete Are you OK with this?

Just to be clear, though: on one hand the colour is hard-coded in the sense that the face does not take terminal attributes into account; on the other hand it is not hard-coded in that you and all custom themes are free to customise it to your liking, e.g. via (set-face-foreground 'hackernews-link nil) or face remapping.

clarete commented 6 years ago

I'm definitely OK with this too! Any changes that makes software integrate smoothly with the environment it runs on is usually a good idea in my opinion! Thanks a lot for the contribution!

basil-conto commented 6 years ago

Thanks!