search

clarete / hackernews.el

Hacker News client for Emacs
GNU General Public License v3.0
248 stars 26 forks source link

Support unvisiting links #53

Closed basil-conto closed 6 years ago

basil-conto commented 6 years ago

Re: #33, #48 Cc: @matthew-piziak

Questions

  1. Can anyone see anything wrong or potentially problematic in the future with this addition? As an example of attempted future-proofing, I opted for a separate "mark unvisited" command instead of extending the "mark visited" command to take a prefix argument, in case we want to use the prefix argument for a different purpose in the future, e.g. to mark an arbitrary number of links as visited. Do you think this is a sensible consideration?
  2. What do you think of the default key binding R for unvisiting?
clarete commented 6 years ago

I really prefer separate commands! Introducing R to be the counterpart of r felt really natural. Probably it's the same way that other Emacs plugins that I've used present this sort of "toggling" feature. So it was pretty natural to me. It's great that it also makes things more flexible!

basil-conto commented 6 years ago

Thanks everyone!