nus-pe-bot
commented
6 months ago Team's Response
While it is not stated in the user guide, it does not make sense for the user to increase or decrease a habit count by a decimal. The definition of "complete" means "to finish doing something", hence completing a habit can only be binary, either one completes it or not, therefore one cannot complete a habit by a decimal point, and can only be in integer form.
In addition, the error message "Please enter a valid count" is appropriate as the user has indeed entered an invalid habit count which is a decimal.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: While I understand the dev team's concern, as a user I do think it is better to be more explicit when it comes to what a user is allowed/not allowed to input. Especially because for the other features from the team, e.g. sleep add, the user is allowed to put decimal numbers. Thus as a user, it was natural for me to similarly input decimal numbers in habit update.
Additionally, i disagree with the dev team's assumption that "it does not make sense for the user to increase or decrease a habit count by a decimal". Since the UG and exception message did not specify the need for integer values, if I were to want to build a habit of drinking water, it would make sense for me to increment the count per cup of water i drank. In this case, decimal numbers (e.g. 1.5 cups of water) is a reasonable input from the user's point of view. Hence, I would still consider this a Low Functionality Bug and recommend for a better exception message to define what a "valid count" is.
User Guide:
Screenshot:
Input Command: habit update /id 1 /by -0.1
As per UG, the only restriction for INCREMENT_COUNT is that it should be numerical. However, if i were to input a decimal value (technically numerical), the error message is that my count is not valid.
Perhaps the exception message could be updated to notify users that only integer values are allowed.