clarin-eric / LRSwitchboard

DEPRECATED - Please see https://github.com/clarin-eric/switchboard for latest version - Code Repository for the Language Resources Switchboard of CLARIN
Other
1 stars 0 forks source link

Add CI integration and mangle env variables #62

Closed andmor- closed 5 years ago

andmor- commented 5 years ago

This PR introduces changes under two scopes:

I still have to document this new build strategy. But for now everyone can build things as usual, just do not commit the package-lock.json file (which should not be a problem if you build using npm install since it only generates the file but does not use it. Note that the CI builds using npm ci which actually uses the package-lock.json file). If we want to build locally using the new strategy, a script was created to facilitate it: run build-with-docker.sh and your build output will be on /build directory.

If you want to run a development environment where you can develop and build inside docker using the same strategy, run from the root of this repository: docker run -v $(pwd):/LRSwitchboard -i -t registry.gitlab.com/clarin-eric/docker-alpine-clrs-build_env:1.0.2 When building like this you can commit the generated package-lock.json since it was generated inside the same image that the CI uses to build the code.

If there are no objections, after this PR is merged I will transfer #60 to a different private repository and make this one public again, so that the whole docker CI workflow can work between github and gitlab. The passwords visible on it are always dummies and the labels are changed by the build before deployment.