search

clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
43 stars 53 forks source link

Data-HR sample #528

Closed 5roop closed 1 year ago

5roop commented 1 year ago

Sample of HR data.

Current prime minister was added manually so that the data validates. For the whole collection we won't be adding them as discussed in #398.

matyaskopp commented 1 year ago

@5roop I guess that HR data are in 5roop:data_hr branch, not in 5roop:data, so this pull request should be replaced with: https://github.com/clarin-eric/ParlaMint/compare/data...5roop:ParlaMint:data_hr

5roop commented 1 year ago

Yes, I started with local branch data as per contributing guidelines, but I soon realized this won't work for submitting 3 corpora. Please advise on next steps, should I close it and create a new PR?

matyaskopp commented 1 year ago

Yes, I started with local branch data as per contributing guidelines, but I soon realized this won't work for submitting 3 corpora. Please advise on next steps, should I close it and create a new PR?

yes, it would be best. and you can also remove 5roop:data branch to avoid confusion.

5roop commented 1 year ago

Closed and opened #559.