clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
41 stars 52 forks source link

Data RS Sample #530

Closed 5roop closed 1 year ago

5roop commented 1 year ago

Adding RS sample. As with HR, only the incumbent prime minister has been encoded.

matyaskopp commented 1 year ago

@5roop validation is failing on this line: https://github.com/5roop/ParlaMint/blob/121d25b6305be106a42b36d1af9ef31fff7335fe/Data/ParlaMint-RS/ParlaMint-RS_1998-10-20-0.xml#L101

            <settingDesc>
                <setting>
                    <name type="address">Trg Nikole Pašića 13</name>
                    <name type="city">Belgrade</name>
                    <name type="country" key="SR">Serbia</name>
<!-- expecting attribute when: -->
                    <date from="1997-12-03" to="2000-10-09" ana="#parla.meeting"> 1997-12-03 - 2000-10-09</date>
                </setting>
            </settingDesc>

is this correct?

if so, then, @TomazErjavec , this should be fixed: https://github.com/clarin-eric/ParlaMint/blob/83150ce35776d9190bff569a6d1b10a8e12edf7f/Scripts/parlamint-lib.xsl#L41-L50


BTW. I guess that

<name type="country" key="SR">Serbia</name>

should be (RS)

<name type="country" key="RS">Serbia</name>
5roop commented 1 year ago

@matyaskopp thanks, the file in question was not updated with the others, this is now fixed with the latest commit

Regarding country keys: my RS sample is corrected, but for the full scale change I suggest that @TomazErjavec fix his copy, as he implemented quite a few other fixes after my submission, does that make sense?

TomazErjavec commented 1 year ago

for the full scale change I suggest that @TomazErjavec fix his copy, as he implemented quite a few other fixes after my submission, does that make sense?

Not really, all my fixes were either mirrored by you, or they are automatic. So, for me not to mess up things further, could you pls. resend the complete RS?

5roop commented 1 year ago

Ok, will do!

On Thu, 26 Jan 2023 at 09:27, Tomaž Erjavec @.***> wrote:

for the full scale change I suggest that @TomazErjavec https://github.com/TomazErjavec fix his copy, as he implemented quite a few other fixes after my submission, does that make sense?

Not really, all my fixes were either mirrored by you, or they are automatic. So, for me not to mess up things further, could you pls. resend the complete RS?

— Reply to this email directly, view it on GitHub https://github.com/clarin-eric/ParlaMint/pull/530#issuecomment-1404685269, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALOMTWEHR6V72MAQP4BI2DLWUIYQ7ANCNFSM6AAAAAAS7XWJM4 . You are receiving this because you were mentioned.Message ID: @.***>

-- http://www.linkedin.com/in/rupnikpeter