clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
50 stars 53 forks source link

Schema: Schizophrenic renaming style #582

Open matyaskopp opened 1 year ago

matyaskopp commented 1 year ago

We have two styles of renaming:

  1. person renaming: https://github.com/clarin-eric/ParlaMint/blob/5deaeed5ae792f3ba1726072298885b5b64a6d64/Data/ParlaMint-AT/ParlaMint-AT-listPerson.xml#L76-L77
  2. org renaming https://github.com/clarin-eric/ParlaMint/blob/a3cb2ecee74cd8925b0aa37831812703638c7b4e/Data/ParlaMint-HU/ParlaMint-HU-listOrg.xml#L632-L635

To be honest, I like more the first solution because it probably reflects better reality.

I know it is probably too late to change this...

@TomazErjavec, what do you think? What was the reason for adding renaming as a relation between organizations?

TomazErjavec commented 1 year ago

I like more the first solution because it probably reflects better reality.

I agree, it is also simpler.

I know it is probably too late to change this...

Maybe - I am considering if we should for 3.1 implement a script like v30tov31 that would implement systematic changes where we consider them to be beneficial. The partners could change their own corpus if they want to, otherwise we do it for them. But you never liked this approach, so... Anyway, we can discuss it after 3.0 is published.

What was the reason for adding renaming as a relation between organizations?

This goes all the way back to sloParl and Andrej Pančur's decision to do it this way, and was simply carried on from there.

matyaskopp commented 1 year ago

ok, I will use the old style in ParlaMint-UA and we can change it later.

TomazErjavec commented 1 year ago

Moving this to future.