search

clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
41 stars 52 forks source link

xml2vert is not covering all cases in notes #585

Closed matyaskopp closed 1 year ago

matyaskopp commented 1 year ago

I think that https://github.com/clarin-eric/ParlaMint/blob/5deaeed5ae792f3ba1726072298885b5b64a6d64/Scripts/parlamint2xmlvert.xsl#L109-L123

should be extended with

<xsl:otherwise>
  <xsl:value-of select="concat(name(), ':-')"/> 
</xsl:otherwise>

because it does not cover this case:

<kinesic>
  <desc>Az elnök a csengő megkocogtatásával jelzi az időkeret leteltét.</desc>
</kinesic>

so in NoSketch it shows empty note.type: https://www.clarin.si/noske-beta/parlamint30.cgi/wordlist?corpname=parlamint30_hu;wlmaxitems=1000;wlattr=note.type;wlminfreq=1;include_nonwords=1;wlsort=f;wlnums=docf

TomazErjavec commented 1 year ago

Well spotted & fixed.