search

clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
41 stars 52 forks source link

fix parliamint2conllu in GitHub actions and Makefile #643

Closed matyaskopp closed 1 year ago

matyaskopp commented 1 year ago

https://github.com/clarin-eric/ParlaMint/actions/runs/4923224888/jobs/8794813287#step:4:185

Scripts/parlamint2conllu.pl script is used in

  1. GitHub actions: https://github.com/clarin-eric/ParlaMint/blob/91ba6eb0c7e82240638c5b11e25c47237b8be619/.github/actions/ParlaMintValidate/validate.sh#L43 but it has been removed in e1736f7a5e87b94e28bf02e88fd546188b1330f3

  2. Makefile https://github.com/clarin-eric/ParlaMint/blob/91ba6eb0c7e82240638c5b11e25c47237b8be619/Makefile#L259-L266

TomazErjavec commented 1 year ago

Oh dear, sorry about this; I wasn't aware (but should've checked of course) that it is used. Namely, there there is also parlamintp2conllu.pl which I use for preference, and thought parlamint2conllu.pl is redundant. Added it back in 17a7864.