search

clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
41 stars 52 forks source link

UA: lower cased languages #700

Closed TomazErjavec closed 1 year ago

TomazErjavec commented 1 year ago

In English, the names of languages should be in upper case, but UA has them in lower case: https://github.com/clarin-eric/ParlaMint/blob/c68b7fe2bc4f27a85e8e8dbe08545035d0dc179e/Data/ParlaMint-UA/ParlaMint-UA.xml#L135-L142.

This should be fixed to English, Ukrainian, Russian both in plain text and .ana roots.

matyaskopp commented 1 year ago

this is already fixed in ParlaMint-UA-finalize script: https://github.com/ufal/ParlaMint-UA/commit/74db5ef0602b8ef9419feca889306cf5772f8de0 it should be ok in the next release - but leaving this opened

AnnaParla commented 1 year ago

I have fixed it there as well. https://github.dev/clarin-eric/ParlaMint/blob/c68b7fe2bc4f27a85e8e8dbe08545035d0dc179e/Data/ParlaMint-UA/ParlaMint-UA.xml

TomazErjavec commented 1 year ago

Note that this is now fixed in parlamint2release.xsl as well. Given that this is now fixed also in source, can we close this issue?

matyaskopp commented 1 year ago

ok, closing