Closed hpreki closed 1 year ago
the 1st pull request failed because
@role
federatedState
is not yet part of the Schema in data
branch - only in the branch documentation
add-common-content
now adds a new subcorpus-type #war
which is not yet part of my ParlaMint-taxonomy-subcorpus.xml
@matyaskopp is there any action required from my side? I suppose you would update the Schema in the data
branch?In the meantime I updated Data/ParlaMint-taxonomy-subcorpus.xml
in my fork but I will wait with a new pull-request until Schema/ParlaMint.*
has been brought up to date ( I did not dare to simply copy the files from the documentation
branch to the data
branch because there are some tiny differences apart from the federatedState
)
This is a very old pull request - is it still relevant, or can we close it?
@TomazErjavec is there a chance we can still finish this pull request? Especially I would like to see Data/ParlaMint-AT/ParlaMint-AT-listPerson.xml
be up to date in the repo. (The current version in the repo is outdated and would not validate. A correct(ed) version of listPerson was handed in to you as part of our submission for ParlaMint-3.1, but this was via a Web-share and never made it into the git-repo.)
@TomazErjavec is there a chance we can still finish this pull request?
I don't think we can, because the repo structure has changed in the meantime (we don't have Data/ anymore, rather, Samples/). But @matyaskopp is more in tune with the git maintenance. In any case, your files will make it to GitHub, but now with everybody sending fixes and translations, it is a bit chaotic.
@hpreki
there is an isssue that your repo is out of date and the Data
folder has been renamed to Sample
I think this procedure will work:
cp -r Data/ParlaMint-AT ParlaMint-AT-BACKUP
git rm Data/ParlaMint-AT/ParlaMint-AT-listOrg.xml \
Data/ParlaMint-AT/ParlaMint-AT-listPerson.xml \
Data/ParlaMint-AT/ParlaMint-AT.ana.xml \
Data/ParlaMint-AT/ParlaMint-AT.xml \
Data/ParlaMint-AT/ParlaMint-AT_2005-03-31-022-XXII-NRSITZ-00100.ana.xml \
Data/ParlaMint-AT/ParlaMint-AT_2005-03-31-022-XXII-NRSITZ-00100.xml \
Data/ParlaMint-AT/ParlaMint-AT_2014-09-24-025-XXV-NRSITZ-00042.ana.xml \
Data/ParlaMint-AT/ParlaMint-AT_2014-09-24-025-XXV-NRSITZ-00042.xml \
Data/ParlaMint-AT/ParlaMint-taxonomy-NER.ana.xml \
Data/ParlaMint-AT/ParlaMint-taxonomy-speaker_types.xml \
Data/ParlaMint-AT/ParlaMint-taxonomy-subcorpus.xml
git commit -m "remove AT files" Data/ParlaMint-AT
git push
Sample/PArlaMint-AT
)@matyaskopp thanks a lot for your detailed "cooking recipe"! I followed your advice, and the pull request looks much better to me right now: it seems to me that it passed all checks.
new sample for ParlaMint-3.1: