search

clarin-eric / ParlaMint

ParlaMint: Comparable Parliamentary Corpora
https://clarin-eric.github.io/ParlaMint/
50 stars 53 forks source link

EE: how to solve affiliation collision? #851

Closed TomazErjavec closed 7 months ago

TomazErjavec commented 8 months ago

With the new to/from fix, those errors are gone from EE. However, it still doesn't validate which is a pain.

@matyaskopp, and idea what to do about this?

Btw. the error messages don't tell you the person, because they can't? Right now it is a bit difficult to find where the errros actually are. I guess there are two, so 4 lines, 2 for TEI, 2 for ana:

ERROR[01] ParlaMint-EE-listPerson affiliation collision: (2014-11-03 --- 2015-04-08) has multiple days overlap with (2014-11-04 --- 2015-04-09) affiliation member-#government.Valitsus
ERROR[01] ParlaMint-EE-listPerson affiliation collision: (2014-11-03 --- 2015-04-08) has multiple days overlap with (2014-11-04 --- 2015-04-09) affiliation member-#government.Valitsus
ERROR[01] ParlaMint-EE-listPerson affiliation collision: (2014-11-03 --- 2015-04-08) has multiple days overlap with (2014-11-04 --- 2015-04-09) affiliation member-#government.Valitsus
ERROR[01] ParlaMint-EE-listPerson affiliation collision: (2014-11-03 --- 2015-04-08) has multiple days overlap with (2014-11-04 --- 2015-04-09) affiliation member-#government.Valitsus
matyaskopp commented 8 months ago

this is the collision:

      <affiliation ref="#government.Valitsus" role="member" from="2014-11-03" to="2015-04-08">
         <roleName xml:lang="et">Liige</roleName>
         <roleName xml:lang="en">Member</roleName>
      </affiliation>
      <affiliation role="member" ref="#government.Valitsus" from="2014-11-04" to="2015-04-09"/>

The merging script also looks into the affiliation/roleName element and if they are different, then they are not merged. but probably in the member-role case, they can be merged

There can also be problems with affiliation/@source and affiliation/orgName that I am ignoring in the affiliation comparison: https://github.com/clarin-eric/ParlaMint/blob/58c4042802ed77843d1f1e535addbb6909bf9d2a/Scripts/parlamint-lib.xsl#L729-L748

TomazErjavec commented 8 months ago

The merging script also looks into the affiliation/roleName element and if they are different, then they are not merged. but probably in the member-role case, they can be merged

Yes, I think so. So, will you do this? Then EE ERROR should go away.

There can also be problems with affiliation/@source and affiliation/orgName that I am ignoring in the affiliation comparison:

Well, maybe let's see if there are any cases like this, before trying to solve all the theoretically possible problems I guess.

matyaskopp commented 8 months ago

Yes, I think so. So, will you do this? Then EE ERROR should go away.

done