search

clarin-eric / VLO

Virtual Language Observatory
GNU General Public License v3.0
14 stars 6 forks source link

Use CMDI 1.2 versions of vocabulary components #3

Closed twagoo closed 7 years ago

twagoo commented 8 years ago

The VloConfig.xml file specifies the locations of a number of components that are parsed and used as vocabularies during import:

<VloConfig>
 ...
 <countryComponentUrl>http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/components/clarin.eu:cr1:c_1271859438104/xml</countryComponentUrl>
 <language2LetterCodeComponentUrl>http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/components/clarin.eu:cr1:c_1271859438109/xml</language2LetterCodeComponentUrl>
 <language3LetterCodeComponentUrl>http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/components/clarin.eu:cr1:c_1271859438110/xml</language3LetterCodeComponentUrl>
 ...
</VloConfig>

(from VLO 4.0)

It would be more consistent to use the CMDI 1.x versions instead, i.e.:

<VloConfig>
 ...
 <countryComponentUrl>http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/1.x/components/clarin.eu:cr1:c_1271859438104/xml</countryComponentUrl>
 <language2LetterCodeComponentUrl>http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/1.x/components/clarin.eu:cr1:c_1271859438109/xml</language2LetterCodeComponentUrl>
 <language3LetterCodeComponentUrl>http://catalog.clarin.eu/ds/ComponentRegistry/rest/registry/1.x/components/clarin.eu:cr1:c_1271859438110/xml</language3LetterCodeComponentUrl>
 ...
</VloConfig>

This seems to work "out of the box" already (because the way that vocabulary items are represented is similar enough between CMDI versions), but needs some (more) thorough testing before it should be applied.

teckart commented 7 years ago

The code is indeed robust enough to support the 1.x versions without any changes.