search

clarin-eric / VLO

Virtual Language Observatory
GNU General Public License v3.0
14 stars 6 forks source link

Upgrade rasa #346

Closed wowasa closed 1 year ago

wowasa commented 2 years ago

Starting with version 5.1.0 Rasa leaves the choice of the database driver and the use of hikari cp to the user. If you add mariadb driver and hikari cp as dependencies to the project, everything should work as before, if you use RasaFactoryBuilderImpl.getRasaFactory(Properties properties).

BUT in my view there is no need to upgrade for version 5.1.0+, since, despite of the driver choice, it has just two new methods which the VLO doesn't use

twagoo commented 2 years ago

Note: decided to stay with 5.0.2 for VLO 4.11.0, as changes are required to accommodate for removed and deprecated methods

wowasa commented 2 years ago

this reminds me that, unless VLO is using Spring Boot, there will be the same issue to use curation persistence as in linkchecker

twagoo commented 2 years ago

VLO uses Spring. Boot shouldn't be necessary.

twagoo commented 1 year ago

VLO 4.11.3 will use linkchecker-persistence and no longer support RASA

twagoo commented 1 year ago

(see #360)