clarin-eric / VirtualCollectionRegistry

Virtual Collection Registry (VCR)
GNU General Public License v3.0
2 stars 0 forks source link

More friendly feedback if validation of incoming collection creation request fails #2

Closed twagoo closed 5 years ago

twagoo commented 7 years ago

See the following report from Thorsten (Uni Tübingen). The underlying problem is invalid handles in the metadata records passed by the VLO (or other application). Considering that the users faced with potential validation errors are coming from another application and are not users from the VCR, it is quite important that they a) are presented with a friendly (or at least not scary) error message and b) get the option to return to where they were coming from. For the latter point, the submitting application should perhaps be allowed to pass an optional 'return on error' URL.


Hi all,

me (again). I saw this nice feature of creating virtual collections from VLO search results, however, something does not work for me:

  1. Logging in with my home institution (when prompted) creates a blank page, seems to me that there is a Shibboleth problem. I think Martin Matthiesen had a nice suggestion for a Shibboleth error page, listing the attributes that were provided and the ones required but not provided, asking a user to contact their IDP. I think that would be a good standard error message and preferable to a blank page for me. At first I thought of course that this is a VLO issue, then noticed that it might be VCR and then guessed that it is actually my IDP, but I don't know which attribute is missing so I don't know what to tell my IDP (who will tell me that they release all required attributes I asked for).

  2. When creating a virtual collection using the clarin IDP I receive a

400 Bad Request

Could not create virtual collection. Reason: one or more references are not valid: [11022/0000-0000-2417-E, 11022/0000-0000-20DF-1, 11022/0000-0000-20E2-C, 11022/0000-0000-20E3-B, 11022/0000-0000-20E0-E, 11022/0000-0000-20DE-2]

This error message is problematic for a user, though I guess that this is due to some errors in Leipzig in these cases (if I read the handles correctly) or an error occurring due to different origins of resources, I really don't know.

To reproduce what I did:


Facet selection language= German Facet search options:

Multiple value selection behaviour: AND check Only include resources that support content search check Only include collection resources

Resultset 23, connect them via "Create virtual collection from result"


Sorry if these are two different issues, but for me they occurred in the same use case.

Cheers

Thorsten

WillemElbers commented 5 years ago

This issue is focussed at item 2 mention by Thorsten, fixed in https://github.com/clarin-eric/VirtualCollectionRegistry/commit/901060333c4c5cbcc5974778cffc70968e8a6ba2 and https://github.com/clarin-eric/VirtualCollectionRegistry/commit/dd24e64eca5afdfc87a8960bd8a38dcb8a51300c