search

clarin-eric / component-registry-rest

Component Registry back end
GNU General Public License v3.0
2 stars 1 forks source link

Adapt OpenSKOS client to changed API #30

Open twagoo opened 7 years ago

twagoo commented 7 years ago

@olhsha provided the following feedback:

CLAVAS:

https://github.com/clarin-eric/component-registry-rest/blob/master/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/servlet/VocabularyServiceServlet.java#L57

-> conceptscheme , conceptscheme/{id}[.html]

Check: 1) ok: http://145.100.58.150/clavas/public/api/conceptscheme/ 2) ok: http://145.100.58.150/clavas/public/api/conceptscheme/d6b89a32-f6fb-4637-9ac9-8413e46fd26a 3) ok: http://145.100.58.150/clavas/public/api/conceptscheme/d6b89a32-f6fb-4637-9ac9-8413e46fd26a.html

https://github.com/clarin-eric/component-registry-rest/blob/master/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/servlet/VocabularyServiceServlet.java#L65

-> find-concepts

Check:

1) conceptScheme parameter in the list of parameters is obsolete. I have made it "scheme" so it is the same as in picturae code (used by Beeld en Geluid) 2) According to run these examples, it should work for parameters you need, after correcting conceptScheme to scheme.

ok: http://145.100.58.150/clavas/public/api/find-concepts?q=uri:*&scheme=http://openskos.meertens.knaw.nl/Organisations&rows=500 ok: http://145.100.58.150/clavas/public/api/find-concepts?q=uri:*505*&scheme=http://openskos.meertens.knaw.nl/Organisations&rows=500&fl=prefLabel

CCR:

https://github.com/clarin-eric/component-registry-rest/blob/master/ComponentRegistry/src/main/java/clarin/cmdi/componentregistry/servlet/ConceptRegistryServlet.java#L82

1) Examples similar to examples above, like

ok: http://145.100.58.150/ccr/public/api/find-concepts?q=*&scheme=http://hdl.handle.net/11148/CCR_P-Morphosyntax_c99c78ee-1425-c8f3-33e3-fe2a4b2ec7ca ok: http://145.100.58.150/ccr/public/api/find-concepts?q=*A*&scheme=http://hdl.handle.net/11148/CCR_P-Morphosyntax_c99c78ee-1425-c8f3-33e3-fe2a4b2ec7ca ok: http://145.100.58.150/ccr/public/api/find-concepts?q=A&wholeword=true (new! "wholeword")

Need to know exact query parameters you use for CCR, for more thorough check.