search

clarin-eric / generate_language_info_pages

Generates language info HTML pages for the CLARIN Virtual Language Observatory.
0 stars 1 forks source link

Generated results deployed to releases #5

Closed MichalGawor closed 4 years ago

MichalGawor commented 4 years ago

On tagged commits compressed results are deployed. Output version to be specified in travis configuration file.

MichalGawor commented 4 years ago

Looks good to me! Only change I propose is to make the filename of the tarball that is deployed a constant. It's a good idea to keep this configurable via .travis.yml but I think it's better to get rid of LANGUAGE_PAGES_VERSION and keep the filename the same across releases. In the other places where LANGUAGE_PAGES_VERSION is used, perhaps we can use the commit id and/or tag name instead?

Ok, no problem. I just noted that in case of untagged commit build should break instantly, but now it goes through and breaks on deploy, also to be fixed.