search

clarin-eric / standards

work space for the Standards and Interoperability Committee
https://www.clarin.eu/content/standards
4 stars 15 forks source link

extra line feeds in the encoded commit IDs #321

Closed bansp closed 1 month ago

bansp commented 1 month ago

That's a funny one... and it's not signalled by the user agent, but only by validators.

How to recreate: open e.g. https://standards.clarin.eu/sis/views/view-centre.xq?id=BBAW and do Ctrl+U or an equivalent to see the source. Search for "commit", and

  1. the first match is the "suggest a fix or extension", with the fragment recommendations of centre ID="BBAW", webCommitId=
2b993c3"

  2. the next two (at the time of posting) matches concern formats without documentation, with fragments format ID="fTCF", commitId=
2b993c3">

  3. the last match, at the very bottom, has this: /
2b993c3cf7f76822be3a93451942e43e5d74f6a7
">

In all three cases, the problem is the 
 entity (twice in (3)).

Not sure where that is coming from.

bansp commented 1 month ago

Got it, I think. Recreated the post-merge hook and this is what I see:

<commitId>
7fb78b9137632999839e129976f084a0caf49d6d
</commitId>
bansp commented 1 month ago

Haha, and there's one more thing. Because of those newlines, the substring only contained 7 numbers, not 8. Got that fixed.