search

clarin-eric / switchboard-tool-registry

The Switchboard Tool Registry
GNU General Public License v3.0
4 stars 13 forks source link

Update Clarin-PL tools to use new services page #170

Closed daawidziu closed 1 month ago

daawidziu commented 2 months ago

Deleted tools definitions that are no longer maintained. Updated other tools to use new page instead of old one.

andmor- commented 1 month ago

Please fix validation errors in Hatespeech.json and Dewulgaryzator.json See:

andmor- commented 1 month ago

If you need check here how to run the validators locally: https://github.com/clarin-eric/switchboard-tool-registry/blob/master/.github/workflows/main.yml#L18

daawidziu commented 1 month ago

Validation errors should be fixed now

andmor- commented 1 month ago

Would you like this to be propagated to production?

daawidziu commented 1 month ago

I need to fix a few things first. As written in the README, I should be able to test my tools at https://beta-switchboard.clarin.eu/, but I can't see them there. Could you check on that?

andmor- commented 1 month ago

Fixed. The problem was that your PR inserted a duplicated name here: https://github.com/clarin-eric/switchboard-tool-registry/pull/170/files#diff-a42083f1e8ea68dbdba773239a7f1cb5b5d6ffe7c92e452841d497d060d6b4d5R7 and here: https://github.com/clarin-eric/switchboard-tool-registry/pull/170/files#diff-c6a0f425e111860eecded6ca14a8485a3e0cc26aa65fc7bfddd61f4d59f442ddR7

I fixed this here: https://github.com/clarin-eric/switchboard-tool-registry/commit/e0c816b3aa35a93c9634a89a8bbc04883558d7ac

Now now the tools show up as expected. But please verify that the name I changed is as you would like it to be.