search

clarinsi / clarin-dspace

LINDAT/CLARIN digital repository based on DSpace
http://lindat.cz
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Strange licence error / conditions #36

Open TomazErjavec opened 4 years ago

TomazErjavec commented 4 years ago

In latest healthcheck we noticed:

File: [cocoon.log.2020-09-08] Warnings/Errors: [0/13]
    22629:2020-09-08 05:13:22,135 ERROR cocoon.handled  - Could not read resource cocoon://DRI/8/handle/1135/1042/license/agree
    at <map:serialize type="xml"> - resource://aspects/BrowseArtifacts/sitemap.xmap:104:40
    at <map:transform type="Navigation"> - resource://aspects/BrowseArtifacts/sitemap.xmap:47:47

We do not really understand this error messasge, what does it mean?

Second thing: this item (http://hdl.handle.net/11356/1042) has a standard CC BY-NC licence. Yet, unlike other items with this licence, it requires the user to log-in before allowing download of files. We checked the metadata, but cannot find anything forcing this behaviour. Where is this (wrong) requirement hidden?

cyplas commented 4 years ago

We do not really understand this error messasge, what does it mean?

My general (perhaps questionable) understanding from talking to Jozef and Ondrej was that cocoon errors are mostly harmless artifacts which aren't necessarily easy to fix (for instance, see https://github.com/clarinsi/clarin-dspace/issues/10#issuecomment-332584922). So I've tended to pay more attention to other errors. However, please do note if you find that these errors coincide with some kind of visibly problematic behaviour in the application

Second thing: this item (http://hdl.handle.net/11356/1042) has a standard CC BY-NC licence. Yet, unlike other items with this licence, it requires the user to log-in before allowing download of files. We checked the metadata, but cannot find anything forcing this behaviour. Where is this (wrong) requirement hidden?

Indeed, this is mysterious to me too. I've spent some time trying to track this down in the Java code, and have determined that this occurs (for 11356/1042, but not for 11356/1213, which has the same license) if the hibernate query at https://github.com/clarinsi/clarin-dspace/blob/clarin/utilities/src/main/java/cz/cuni/mff/ufal/lindat/utilities/HibernateFunctionalityManager.java#L128 returns any non-null results. However, it's not clear to me what these entities and queries are really about or why 11356/1042 is special, so I'll have to investigate further and/or pester Ondrej (again). Is this issue a priority (best if you use the *-priority github labels we once defined)?