Theme update broke display of form in FE

[patrickkaleta]

After the last update of the theme the forms shown in the Study are broken:

This is caused by an override statement in the info.yml file of the theme right here. For now, I just removed this line of code, since we need to be able to work with the forms right away. But at some point this should get fixed in a different way, since I'm sure @bullz added this override statement for a reason.

Additionally, also the second override statement (assets/vendor/jquery.ui/themes/base/theme.css) should be fixed, since it also breaks the form display in the front-end a little bit. However, I left that statement since its effects are not as dramatic.

[patrickkaleta]

@bullz just so you know, the problem is caused by a missing :before css-rule for .ui-helper-cleafix, which is available in the core.css that was overwritten in the latest theme update.

[DenoBeno]

Fixed now? Excellent.

On Mon, 23 Sep 2019 at 14:46, Patrick Kaleta notifications@github.com wrote:

@bullz https://github.com/bullz just so you know, the problem is caused by a missing :before css-rule for .ui-helper-cleafix, which is available in the core.css that was overwritten in the latest theme update. [image: missing-css_rules] https://user-images.githubusercontent.com/42167036/65426626-e091b800-de10-11e9-92d1-2f51bcd3e1f1.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/clarity-h2020/clarity-theme/issues/11?email_source=notifications&email_token=AAWTC7XNT6EJ2KZFP53V46TQLC3CHA5CNFSM4IZKK3G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7KXK6A#issuecomment-534082936, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWTC7U53TKTV5FB34IRJX3QLC3CHANCNFSM4IZKK3GQ .

[patrickkaleta]

No, it's not yet fixed. I only implemented a workaround by removing a statement, which was added by @bullz in one of his previous theme updates. I'm assuming he added this line for a reason, so he should eventually look into this and fix it properly.

[patrickkaleta]

@bullz please fix this. We just noticed together with @DenoBeno that the Cancel button (X in upper right corner) is not visible, but still functional. So, closing those pop-ups can be quite tricky if the users don't know that there actually is a cancel button hidden in the top corner.

[p-a-s-c-a-l]

Please close this issue if this has been resolved in the updated theme or give feedback on the status.

[patrickkaleta]

No, cancel-buttons are still missing on all the forms. They are there (you can click on them and they work), but they are just not visible to anyone. It is not a permissions issue, this needs to be fixed in the theme. @bullz please take care of that.

[patrickkaleta]

This is now finally fixed!