search

clarity-h2020 / clarity-theme

CLARITY CSIS Drupal Theme
GNU General Public License v3.0
0 stars 0 forks source link

Scenario Analysis app not working properly due to missing seamless.js #2

Closed patrickkaleta closed 5 years ago

patrickkaleta commented 5 years ago

Scenario analysis app is not displayed properly. theme-bug-1

Probably just caused by a missing seamless.js, which was not properly added to the new theme.

After including the clarity/global-scripts in the clarity.info.yml, all additional js files are now included in the theme and working as expected.

p-a-s-c-a-l commented 5 years ago

Perhaps the theme is not the best place? seamless.js is only needed on those pages that inlcude external apps via iFrame and only when those apps are initialised via seamless.js. Currently this is the case for the MCDA App.

patrickkaleta commented 5 years ago

Then perhaps we could move it into the csis helpers module and include it just where it's needed (just like it's the case with the html2canvas.js necessary for taking report image screenshots).

@fgeyer16: any objections to moving the seamless.js from the theme into our custom module?

fgeyer16 commented 5 years ago

any objections to moving the seamless.js from the theme into our custom module?

No o objectives. In contrary, since this is functionality it should be in a module and not in a theme.

patrickkaleta commented 5 years ago

Done. Seamless.js is now inside the csis helpers module and currently loaded just for GL-steps, since they are the only entity type, where the MCDA app is available.