search

clarity-h2020 / clarity-theme

CLARITY CSIS Drupal Theme
GNU General Public License v3.0
0 stars 0 forks source link

Need better styling of datapackage and resource forms #8

Closed patrickkaleta closed 4 years ago

patrickkaleta commented 5 years ago

The current theme is not so great for when the user tries to edit/create resources or data packages. Main problem IMO is that we need better separation between the actual entity that is being edited and any potential referenced entities, which can be edited inline. See for e.g. this screenshot: styling of forms

There I'm editing this datapackage and wanted to edit an entry in the "Other sources" field. This opens an inline form and I cannot tell where this inline form starts and where it ends (I highlighted it with the Browser console). Since there are so many fields in these forms, it gets quite confusing even for someone who modelled the data structure of this thing.

Inline entity form opens those inline forms in a tr element with class "ief-row-form", one idea would be to maybe change the padding and background of those elements to make them "pop out" of the original form.

patrickkaleta commented 4 years ago

@bullz following up on our telco from 1-2 weeks ago, how is the status here? have you been able to make those forms a little more user-friendly?

p-a-s-c-a-l commented 4 years ago

Please close this issue if this has been resolved in the updated theme or give feedback on the status.

patrickkaleta commented 4 years ago

Adressed in this commit For the inline forms showing up in our data package forms (in the Resources/Datasets field) I added an alternating coloring of the items for odd/even elements (just like we have it in other places) and I gave the entity which is being edited directly inside the DP a slighty darker background and a border.

IMO this is now good enough, so I'm closing this issue.