clarity-h2020 / csis-technical-validation

CSIS Technical Validation
https://health-check.clarity.cismet.de/
GNU Lesser General Public License v3.0
0 stars 0 forks source link

CSIS Acceptance Test by ZAMG #53

Closed p-a-s-c-a-l closed 4 years ago

p-a-s-c-a-l commented 4 years ago

As announced here, we now start with the CSIS Acceptance Tests.

Please read the Acceptance Test Specification and follow the 11 steps in the Walkthrough section to test the public BETA of CSIS.

Please report any problems or bugs according to the instructions in the Giving Feedback section.

If you have further questions regarding the general test process, please contact @therter and @p-a-s-c-a-l

therter commented 4 years ago

Have you encountered any problems/bugs?

claudiahahn commented 4 years ago

Thanks for asking! We did not start checking yet. I hope to that (or at least par of it) tomorrow.

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/view/context 19.06.2020, 11:15, grafik

Not sure if the users understands that he has to edit things here (edit button) in order to go further. It might be helpfull to rename the button maybe to "please enter more information here" or "please select your city here", or anything like that

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/view/context https://csis.myclimateservice.eu/study/166/view/context 19.06.2020, 11:19, grafik it should be Emmission Scenario: RCP 8.5 (worst case) now it shows: Emmission Scenario: worst case scenario But I think Pascal already fixed that in the dev instance?

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/view/data 19.06.2020, 11:28 grafik Shouldn't there be more contributors listed here? right now: Denis Havlik and Pascal Dihé

claudiahahn commented 4 years ago

ah ok, after selecting the data package all contributors are listed, please ignore my post above

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/group/166/edit/trigger?destination=/study/166/view/summary 19.06.2020, 11:39 grafik afer clicking the button to start the calculations, I received the error message

claudiahahn commented 4 years ago

but going back and clicking the button again, the calculations started

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/step/4595/view/table 19.06.2020, 15:50, choosing a scenario doesn't really change anything in the table view. -->Select scenario button could be removed? I description explaining what is provided in the table is missing

claudiahahn commented 4 years ago

grafik

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/step/4595/view/maps 19.06.2020,16:04 grafik tropical nights mean and std should be displayed map for standard deviation is not shown only the units are displayed in the legend. It would be very usefull to also display the layer name

claudiahahn commented 4 years ago

btw: Firefox 77.0.1 (64-Bit)) Windows10

claudiahahn commented 4 years ago

grafik

claudiahahn commented 4 years ago

grafik

grafik

p-a-s-c-a-l commented 4 years ago

it should be Emmission Scenario: RCP 8.5 (worst case) now it shows: Emmission Scenario: worst case scenario But I think Pascal already fixed that in the dev instance?

yes

RobAndGo commented 4 years ago

I think Emissions Scenario rather than Emmission Scenario would make me happier. Note the use of plural Emissions, as can be found here.

claudiahahn commented 4 years ago

sorry, my mistake (also the extra m...). It's correct in CSIS (emissions)

p-a-s-c-a-l commented 4 years ago

I think Emissions Scenario rather than Emmission Scenario would make me happier. Note the use of plural Emissions, as can be found here.

In CSIS-DEV it is called "Emissions Scenario: RCP 8.5 (worst case)"

choosing a scenario doesn't really change anything in the table view. -->Select scenario button could be removed? I description explaining what is provided in the table is missing

Select scenario button is working now. Table description is now taken from EMIKAT:

image

p-a-s-c-a-l commented 4 years ago

after clicking the button to start the calculations, I received the error message

This is being addressed here

map for standard deviation is not shown

Hm, perhaps just a temporary error? I'm able to see the layer: image

only the units are displayed in the legend. It would be very useful to also display the layer name

This is being discussed here and here

p-a-s-c-a-l commented 4 years ago
  • the wind indices are under "default"? it should be wind indices or even under the respective wind index

done, except for Wind98p. This is being addressed here

  • Also consecutive frost days are listed under consecutive summer days

done (in CSIS -DEV)

  • the wind indices are all displayed with units "days", even though only for the torro17 index the units are days, for the rest the units should be m/s

This is being addressed here

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/step/4595/view/maps hazard characterisation step. , 26.06.2020, 15:41 grafik

Nothing is displayed (except "Legend") when choosing Urban Atlas 2012 or Urban Atlas 2012 (Building height)

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/step/4595/view/maps 26.06.2020, 15:44

grafik Pascal mentioned in some other issue, that it would be an option to try and get the data and define the color scale --> that would be useful, because now, it is difficult to differentiate between the classes

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/step/4595/view/maps hazard characterisation, 26.06.2020, 15:49 grafik legend entries are hard to read

claudiahahn commented 4 years ago

https://csis.myclimateservice.eu/study/166/step/4595/view/maps hazard characterisation, 26.06.2020, 15:51 grafik the legend is not good, having blue then purple and then blue again.

RobAndGo commented 4 years ago

Maybe the following comment will fit better here. Originally it was posted (via @p-a-s-c-a-l ) here

As I do not know how the colour bar legend is implemented in the map view, I will upload an example of a rather pleasing (to me at least) colour scale which can be used for all heat indices: heat_colourbar.rgb.txt

It's an ASCII file (remove the temporary .txt extension) and gives the red, green, blue values on a scale from 0-1 for each level. In this case there are 16 colour levels defined (ncolors= 16), and after the comment line (# r g b), the rgb values are defined.

For the cold indices, one would simply need to reverse the order of the colours in the file, which I have done here: cold_colourbar.rgb.txt

It comes from this website here which has lots of examples of colourbars and their corresponding RGB values.

In general, using stepped rather than continuous colourbars make differences easier to see.

All indices involving precipitation could use this colour scale:

precip_diff_12lev.rgb.txt

p-a-s-c-a-l commented 4 years ago

Unfortunately, we have no influence on the layers from the group Backgrounds. Of course, those that are based on open data like Corine Land Cover, etc. could be imported in our own GeoServer, but it's up to @DanielRodera @maesbri to decide if they want to take over this task.

Styling of own layers is discussed here.

DanielRodera commented 4 years ago

Hi @p-a-s-c-a-l, I have taken a look with Miguel Angel to the Corine Land Cover layer.

We find out that Copernicus is offering a WMS endpoint for CLC. Here you can find more info.

I guess this layer can be added directly to our CSIS taking advantage they are already serving this dataset for free.

What do you think??

p-a-s-c-a-l commented 4 years ago

Thanks @DanielRodera, but it's not about just adding CLC/UA layers available from external services. In fact, all layers in group Backgrounds are external layers. It's about the ability to modify the appearance of these layers as requested by @claudiahahn here.

That will IMHO only work if the layers are under our full control (managed in our geoserver). But perhaps there is a possibility to change the styles via a getMap parameter @therter? But I don't think that we are able to "inject" our own styles. So IMHO our only possibility is to download the raw data and serve these layers ourselves.

claudiahahn commented 4 years ago

02.07.2020, 10:48 https://csis.myclimateservice.eu/study/113/step/3630/view/maps grafik the background and hazard layers ar not shown in the drop down menu and thus cannot be selected that problem occured with Firefox 60.0.1 (64-Bit), using Chrome (83.0.4103.116) it works, the layers are displayed and can be selected

p-a-s-c-a-l commented 4 years ago

Hm, works for me: grafik

Is there an error on the console? (Press CTRL+SHIFT+i, reload the page). The list of layers is retrieved from the Data Package via CSIS DrupalAPI, so perhaps the problem is on that side. On the other hand, your Firefox is pretty old, the current version is 78.0.1.

claudiahahn commented 4 years ago

I guess it's the firefox version ...

claudiahahn commented 4 years ago

one can add only 5 study scenarios? grafik

patrickkaleta commented 4 years ago

one can add only 5 study scenarios?

Yes, that is currently the limit, which was set this this low on purpose. It's easier to increase that number later on than it is to decrease it (in which case user could potentially lose some of their scenarios if they are above the limit).

Currently we are working on removing the Study variant field from the scenarios, which would lead to less scenarios needed by the users.

claudiahahn commented 4 years ago

Thanks for the explanation!

p-a-s-c-a-l commented 4 years ago

Thanks for testing!